-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-40718][BUILD][CONNECT][FOLLOWUP] Explicitly add Netty related dependencies for the connect
module
#38185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
changed the title
[SPARK-40718][BUILD][FOLLOWUP] Explicitly add Netty related dependencies for the
[SPARK-40718][BUILD][CONNECT][FOLLOWUP] Explicitly add Netty related dependencies for the Oct 10, 2022
connect
moduleconnect
module
grundprinzip
approved these changes
Oct 10, 2022
HyukjinKwon
approved these changes
Oct 10, 2022
zhengruifeng
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LuciferYang
commented
Oct 10, 2022
@@ -187,8 +187,12 @@ metrics-jvm/4.2.10//metrics-jvm-4.2.10.jar | |||
minlog/1.3.0//minlog-1.3.0.jar | |||
netty-all/4.1.80.Final//netty-all-4.1.80.Final.jar | |||
netty-buffer/4.1.80.Final//netty-buffer-4.1.80.Final.jar | |||
netty-codec-http/4.1.80.Final//netty-codec-http-4.1.80.Final.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the new 4 jars about 1232KB
GA passed |
Merged to master. |
+1, very late LGTM. Thank you. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
After #38179, there are 2 netty version in Spark:
connect
moduleSo this pr explicitly add netty related dependencies for the
connect
module to ensure Spark use unified netty version.Why are the changes needed?
Ensure Spark use unified netty version.
Does this PR introduce any user-facing change?
No
How was this patch tested?
run
mvn dependency:tree -pl connector/connect | grep netty
Before
After